[haiku-commits] Re: haiku: hrev50931 - src/servers/app/drawing/Painter
- From: waddlesplash <waddlesplash@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 3 Feb 2017 11:59:16 -0500
On Fri, Feb 3, 2017 at 4:28 AM, Julian Harnath <
This is not right, the above #define has nothing to do with
enabling/disabling subpixel rendering for fonts, it only selects which
filtering method to use for the colour fringe filter. Average-based filter
does not reduce it to greyscale (see  for details).
Simply dropping in a subpixel-enabled freetype library was already enough
to enable it before this commit.
So at least the code comment is now wrong, but also, it should be reasoned
why we'd want this change.
OK, so it appears that I was partially wrong here. But it seems to me that
you're incorrect that this has nothing to do with fonts -- see
- it appears that decompose_ft_bitmap_subpix behaves very differently if
this is not defined?
What would you suggest as a proper wording for the comment?
Other related posts: