[haiku-commits] Re: haiku: hrev50931 - src/servers/app/drawing/Painter

  • From: Julian Harnath <julian.harnath@xxxxxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 3 Feb 2017 11:50:23 +0100

Hey,

On 03.02.2017 11:38, Adrien Destugues wrote:

IIRC, we don't want this average based filter anymore. Freetype has much 
improved its own filters since this was implemented, and we could use their 
default filters now, which are much less subject to color fringes than they 
were back then.

app_server currently never uses freetype's built-in filtering. If the average-based filter is disabled with that #define, it uses another one [0] which is also internal.

However, we should probably expose a setting to pick between the different 
filters available in Freetype:
https://www.freetype.org/freetype2/docs/reference/ft2-lcd_filtering.html

Sure, if it's better than what we have, we should probably use freetype's filters. Not sure if it needs to be a user-setting though, maybe the best one can be picked and set as default.

Regards,
Julian

[0] http://cgit.haiku-os.org/haiku/tree/src/servers/app/font/FontEngine.cpp#n411

Other related posts: