[haiku-commits] Re: haiku: hrev50931 - src/servers/app/drawing/Painter

  • From: Julian Harnath <julian.harnath@xxxxxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 3 Feb 2017 10:28:41 +0100


On 03.02.2017 02:27, waddlesplash@xxxxxxxxx wrote:


d10e64f8517d: app_server: Enable the RGB subpixel rendering codepath.
> [...]
+// Uncommenting the following line will enable the average-based (grayscale)
+// subpixel filter, thus locking RGB subpixel font rendering out of the build.
+// Unless you have a subpixel-enabled FreeType, there shouldn't be a 
+// as FreeType returns the grayscale hinting unless compiled otherwise.

This is not right, the above #define has nothing to do with enabling/disabling subpixel rendering for fonts, it only selects which filtering method to use for the colour fringe filter. Average-based filter does not reduce it to greyscale (see [0] for details).
Simply dropping in a subpixel-enabled freetype library was already enough to enable it before this commit.
So at least the code comment is now wrong, but also, it should be reasoned why we'd want this change.


[0] http://cgit.haiku-os.org/haiku/tree/src/servers/app/drawing/Painter/agg_scanline_p_subpix_avrg_filtering.h#n72

Other related posts: