[haiku-commits] Re: haiku: hrev50905 - in src/apps/haikudepot: server model tar util .
- From: Andrew Lindesay <apl@xxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 31 Jan 2017 21:24:24 +1300
Hello Adrien;
Some comments below about usage of the HTTP classes. Mostly my fault for
still not having written the documentation for them.
Thank you for those tips; I've made most of those changes now.
+/* The output format for this is suitable for use in the
"If-Modified-Since"
+ * header. An example of this output would be;
+ * 'Fri, 24 Oct 2014 19:32:27 +0000'
+ */
I think this is already implemented in BHttpDate.
I wasn't able to find that class in the system. Can you let me know
specifically where that might be and I'll take another look.
+const BString
+ServerSettings::_GetUserAgentVersionString()
Should we make this the default behavior for the HTTP user agent? (create
something from the app info name and version?)
That might be a good idea generally. In this case, I may need to be
more specific with the "User-Agent" header because I need to be able to
detect incompatible clients in the future so may need to retain specific
control over it.
Regards;
--
Andrew Lindesay
Other related posts:
