[haiku-commits] Re: haiku: hrev50832 - in src/system/boot: platform/efi loader
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 7 Jan 2017 23:40:33 +0100
Am 07/01/2017 um 23:02 schrieb Jessica Hamilton:
'*' should go to the type, not the name.
Hmm, I'd really like to see this change =/
typename* t1, t2; // t2 is not a pointer
That's exactly why we don't use this possibility.
Each definition has to be on its own line.
And here, too -- the asterisk style used for the cast is different than what
you're using elsewhere; while the "type *" style is allowed, you must then
be consistent, and use (type *), too.
And then here you say "type *" is allowed, which seems contrary to
your statement earlier?
Since mmlr insisted to be able to continue to use "type *" when we
discussed our new coding style (before we pretty much used OpenTracker
style [1]), we agreed to the compromise that you can use either style,
but you always have to be consistent in one file, and "type*" is preferred.
Does that clear things up or does it make matters worse? :-)
Bye,
Axel.
[1]
http://opentracker.be/guidelines.html
Other related posts: