[haiku-commits] haiku: hrev50751 - src/apps/softwareupdater build/jam/images/definitions

  • From: jscipione@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 9 Dec 2016 22:53:31 +0100 (CET)

hrev50751 adds 4 changesets to branch 'master'
old head: b4ad45f630a45db4043ff5d062fcddb84652585d
new head: 19d8d9fa3983e6687caeab8fe1193861a5202ab6
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=19d8d9fa3983+%5Eb4ad45f630a4

----------------------------------------------------------------------------

7d82a586b01d: SoftwareUpdater: Replace 4 spaces with 1 hard tab

6ff8fbf5684e: SoftwareUpdater: Replace %d with B_PRIu32 for uint32
  
  (gcc2h build gave me a stern warning)

4e23cc438e01: SoftwareUpdater: Swap cancel and default buttons so default is 
rightmost
  
  ... and add default horizontal space between text and buttons

19d8d9fa3983: Add SoftwareUpdater to regular image

                                     [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------

2 files changed, 5 insertions(+), 4 deletions(-)
build/jam/images/definitions/regular               | 2 +-
src/apps/softwareupdater/SoftwareUpdaterWindow.cpp | 7 ++++---

############################################################################

Commit:      7d82a586b01d91606ba8e73e4fde502ab813aec0
URL:         http://cgit.haiku-os.org/haiku/commit/?id=7d82a586b01d
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Fri Dec  9 21:48:37 2016 UTC

SoftwareUpdater: Replace 4 spaces with 1 hard tab

----------------------------------------------------------------------------

diff --git a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp 
b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
index 6c406ff..c1df6bb 100644
--- a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
+++ b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
@@ -100,7 +100,7 @@ SoftwareUpdaterWindow::SoftwareUpdaterWindow()
                .End()
                .AddGlue()
                //.Add(new BSeparatorView(B_HORIZONTAL, B_PLAIN_BORDER))
-    ;
+       ;
        CenterOnScreen();
        Show();
 }

############################################################################

Commit:      6ff8fbf5684e88a52f641cc97e72b11f6aa6fa4e
URL:         http://cgit.haiku-os.org/haiku/commit/?id=6ff8fbf5684e
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Fri Dec  9 21:50:13 2016 UTC

SoftwareUpdater: Replace %d with B_PRIu32 for uint32

(gcc2h build gave me a stern warning)

----------------------------------------------------------------------------

diff --git a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp 
b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
index c1df6bb..b9710c7 100644
--- a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
+++ b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
@@ -63,7 +63,7 @@ SoftwareUpdaterWindow::SoftwareUpdaterWindow()
                headerView = new BStringView("header",
                        "Software updates are available.", B_WILL_DRAW);
                char detailString[1024];
-               snprintf(detailString, 1024, "There are %d updates available"
+               snprintf(detailString, 1024, "There are %" B_PRIu32 " updates 
available"
                        " for your system.", updatesAvailable);
                detailView = new BStringView("detail", detailString, 
B_WILL_DRAW);
                updateButton->MakeDefault(true);

############################################################################

Commit:      4e23cc438e01e006cd7ace6956df12fe8113a88a
URL:         http://cgit.haiku-os.org/haiku/commit/?id=4e23cc438e01
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Fri Dec  9 21:52:03 2016 UTC

SoftwareUpdater: Swap cancel and default buttons so default is rightmost

... and add default horizontal space between text and buttons

----------------------------------------------------------------------------

diff --git a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp 
b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
index b9710c7..c0f211a 100644
--- a/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
+++ b/src/apps/softwareupdater/SoftwareUpdaterWindow.cpp
@@ -92,10 +92,11 @@ SoftwareUpdaterWindow::SoftwareUpdaterWindow()
                                B_USE_DEFAULT_SPACING, B_USE_DEFAULT_SPACING)
                        .Add(headerView)
                        .Add(detailView)
+                       .AddStrut(B_USE_DEFAULT_SPACING)
                        .AddGroup(B_HORIZONTAL, B_USE_DEFAULT_SPACING)
                                .AddGlue()
-                               .Add(updateButton)
                                .Add(exitButton)
+                               .Add(updateButton)
                        .End()
                .End()
                .AddGlue()

############################################################################

Revision:    hrev50751
Commit:      19d8d9fa3983e6687caeab8fe1193861a5202ab6
URL:         http://cgit.haiku-os.org/haiku/commit/?id=19d8d9fa3983
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Fri Dec  9 21:52:27 2016 UTC

Add SoftwareUpdater to regular image

----------------------------------------------------------------------------

diff --git a/build/jam/images/definitions/regular 
b/build/jam/images/definitions/regular
index 168a77c..ad8a9f4 100644
--- a/build/jam/images/definitions/regular
+++ b/build/jam/images/definitions/regular
@@ -24,7 +24,7 @@ SYSTEM_APPS += [ FFilterByBuildFeatures
        Magnify Mail MediaConverter MediaPlayer MidiPlayer
        People PoorMan PowerStatus
        RemoteDesktop
-       Screenshot SerialConnect SoundRecorder
+       Screenshot SerialConnect SoftwareUpdater SoundRecorder
        TV
        WebWatch
 ] ;


Other related posts:

  • » [haiku-commits] haiku: hrev50751 - src/apps/softwareupdater build/jam/images/definitions - jscipione