[haiku-commits] haiku: hrev50621 - src/kits/interface

  • From: jscipione@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 26 Oct 2016 22:41:23 +0200 (CEST)

hrev50621 adds 1 changeset to branch 'master'
old head: 000b15f2c38d03bb75be65385abcc4fa71e4d8d6
new head: 134ed61451d6c384e8cd0383934918a687539646
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=134ed61451d6+%5E000b15f2c38d

----------------------------------------------------------------------------

134ed61451d6: ListView: Fix off-by-1 bug introduced in hrev50574
  
  7687a6ef13359dbac63eaae0b40cb6875873ea71
  
  jgt^He
  
  Fixes #12990 more better
  
  Thanks Humdinger for noticing this bug and reporting it.

                                     [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev50621
Commit:      134ed61451d6c384e8cd0383934918a687539646
URL:         http://cgit.haiku-os.org/haiku/commit/?id=134ed61451d6
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Wed Oct 26 20:36:49 2016 UTC

Ticket:      https://dev.haiku-os.org/ticket/12990

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/kits/interface/ListView.cpp | 2 +-

----------------------------------------------------------------------------

diff --git a/src/kits/interface/ListView.cpp b/src/kits/interface/ListView.cpp
index 5cd11ac..cd12e3f 100644
--- a/src/kits/interface/ListView.cpp
+++ b/src/kits/interface/ListView.cpp
@@ -1958,7 +1958,7 @@ BListView::_DoneTracking(BPoint where)
 void
 BListView::_Track(BPoint where, uint32)
 {
-       if (fTrack->item_index > 0 && fTrack->try_drag) {
+       if (fTrack->item_index >= 0 && fTrack->try_drag) {
                // initiate a drag if the mouse was moved far enough
                BPoint offset = where - fTrack->drag_start;
                float dragDistance = sqrtf(offset.x * offset.x + offset.y * 
offset.y);


Other related posts:

  • » [haiku-commits] haiku: hrev50621 - src/kits/interface - jscipione