[haiku-commits] Re: haiku: hrev50583 - src/add-ons/kernel/bus_managers/ps2 headers/private/kernel build/config_headers build/jam

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 9 Oct 2016 23:04:04 +0200

Am 09/10/2016 um 22:58 schrieb Jessica Hamilton:

+#define        KDL_KEYMAP              KDL_KEYMAP_FR
Shouldn't this be KDL_KEYMAP_US?

Ideally, I think one would be better off doing:

#ifndef KDL_KEYMAP
#define KDL_KEYMAP_US
#endif

This way it can be overridden in the UserBuildConfig.

Actually, you're not supposed to change those headers directly, but copy them to user_config_headers/, and change them there.
If you'd do that, you wouldn't have to worry about changes leaking into the repository accidentally either :-)

Bye,
   Axel.

Other related posts: