[haiku-commits] Re: haiku: hrev50493 - src/preferences/keymap
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 18 Aug 2016 20:26:24 +0200
Am 18/08/2016 um 13:01 schrieb Stephan Aßmus:
AFAICT there is no difference from using an uninitialized ref or a NULL
ref when constructing a file panel.
IOW there shouldn't be any special handling necessary.
Understood. I don't know if you mean the code should stay as it is or
not. It is definitely buggy. What does not work is creating the folder
and then opening the file panel with the just created folder. That's
because "ref" will still not be initialized.
Yes, there is a bug, and it should be fixed, I was just referring to
John's latest question -- I actually didn't notice the bug before you
mentioned it.
And in case "ref" already
points to a file or symlink, I don't know how the file panel will behave.
The panel checks if the ref is a directory, and just falls back to the
default if not (same as when it's NULL, or uninitialized) [1].
Bye,
Axel.
[1]
http://cgit.haiku-os.org/haiku/tree/src/kits/tracker/FilePanelPriv.cpp#n201
Other related posts:
