[haiku-commits] Re: haiku: hrev50448 - src/apps/packageinstaller

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 23 Jul 2016 17:08:11 +0200

Am 23.07.2016 um 16:56 schrieb waddlesplash@xxxxxxxxx:

hrev50448 adds 1 changeset to branch 'master'
old head: 8cf0752f1bde487b7b78c6f375d22181023e32c2
new head: af3057423c2951d7a1652cf7383b2fafe12872b6
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=af3057423c29+%5E8cf0752f1bde

----------------------------------------------------------------------------

af3057423c29: LegacyPackageInstaller: Correct previous commit.

  The test in the previous commit had a totally flawed invocation of strcmp().
  I probably shouldn't attempt to write C code without consulting the manual.

  Even if it had worked, it would have worked on too many cases, including
  some volume paths. So I reordered the if statement and added it in there.

I hope you know what you are doing here, because it would seem you have changed the code that you claim fixed a problem. So why would the problem still be fixed? Why? Or was it not actually tested?

Please also remove or change the misleading comment.

Best regards,
-Stephan


Other related posts: