[haiku-commits] Re: haiku: hrev50444 - src/kits/tracker

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 22 Jul 2016 14:53:19 -0400

I'll check later today, but I glanced at those tickets and I think they are
all still fixed, from my own testing before committing this. I will test
later though.

On Jul 22, 2016 12:28 PM, "John Scipione" <jscipione@xxxxxxxxx> wrote:

On Thu, Jul 21, 2016 at 6:59 PM,  <waddlesplash@xxxxxxxxx> wrote:
e944dacae02c: Tracker: Remove special filtering case from
NewFileFromTemplate.
@@ -3427,15 +3427,6 @@ BPoseView::NewFileFromTemplate(const BMessage*
message)
        BPose* pose = EntryCreated(targetModel->NodeRef(), &destNodeRef,
                destEntryRef.name, &index);

-       if (fFiltering) {
-               if (fFilteredPoseList->FindPose(&destNodeRef, &index) ==
NULL) {
-                       float scrollBy = 0;
-                       BRect bounds = Bounds();
-                       AddPoseToList(fFilteredPoseList, true, true,
pose, bounds, scrollBy,
-                               true, &index);
-               }
-       }
-
        if (pose != NULL) {
                WatchNewNode(pose->TargetModel()->NodeRef());
                UpdateScrollRange();


So this code was useless then?

The commit that added this code supposedly fixed #4254, #5381, #1717
does this change reopen any of those issues?


Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 07-2016