[haiku-commits] haiku: hrev50436 - src/system/kernel/arch/arm

  • From: revol@xxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 20 Jul 2016 18:54:27 +0200 (CEST)

hrev50436 adds 1 changeset to branch 'master'
old head: b33ffcda12fce512058e37962c380600d50d25e6
new head: 181391c106d86810417f7e9cd1c0a969fdc2c5fc
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=181391c106d8+%5Eb33ffcda12fc

----------------------------------------------------------------------------

181391c106d8: ARM: Add TODO on barrier calls, we might need to do more here
  
  They look suspiciously empty.

                                          [ François Revol <revol@xxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev50436
Commit:      181391c106d86810417f7e9cd1c0a969fdc2c5fc
URL:         http://cgit.haiku-os.org/haiku/commit/?id=181391c106d8
Author:      François Revol <revol@xxxxxxx>
Date:        Wed Jul 20 16:53:24 2016 UTC

----------------------------------------------------------------------------

1 file changed, 6 insertions(+)
src/system/kernel/arch/arm/arch_cpu.cpp | 6 ++++++

----------------------------------------------------------------------------

diff --git a/src/system/kernel/arch/arm/arch_cpu.cpp 
b/src/system/kernel/arch/arm/arch_cpu.cpp
index afe8455..e1faebc 100644
--- a/src/system/kernel/arch/arm/arch_cpu.cpp
+++ b/src/system/kernel/arch/arm/arch_cpu.cpp
@@ -100,6 +100,9 @@ arch_cpu_sync_icache(void *address, size_t len)
 void
 arch_cpu_memory_read_barrier(void)
 {
+       // TODO: check if we need more here
+       // (or just call the inline version?)
+       // cf. headers/private/kernel/arch/arm/arch_atomic.h
        asm volatile ("" : : : "memory");
 }
 
@@ -107,6 +110,9 @@ arch_cpu_memory_read_barrier(void)
 void
 arch_cpu_memory_write_barrier(void)
 {
+       // TODO: check if we need more here
+       // (or just call the inline version?)
+       // cf. headers/private/kernel/arch/arm/arch_atomic.h
        asm volatile ("" : : : "memory");
 }
 


Other related posts:

  • » [haiku-commits] haiku: hrev50436 - src/system/kernel/arch/arm - revol