[haiku-commits] Re: haiku: hrev50368 - src/kits/network/libnetapi headers/os/net

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Jun 2016 15:32:40 +0000

On Wed, 22 Jun 2016 2:41 am Rene Gollent <anevilyak@xxxxxxxxx> wrote:

On Mon, Jun 20, 2016 at 7:49 PM,  <waddlesplash@xxxxxxxxx> wrote:
diff --git a/headers/os/net/NetworkAddress.h
b/headers/os/net/NetworkAddress.h
index 865ed73..717108a 100644
--- a/headers/os/net/NetworkAddress.h
+++ b/headers/os/net/NetworkAddress.h
@@ -149,6 +149,7 @@ private:
 private:
                        sockaddr_storage        fAddress;
                        status_t                        fStatus;
+                       BString                         fHostName;
 };


It should be noted that by changing the size of the class, this breaks
binary compatibility. As such, any packages making use of these
classes will need a rebuild, or there will likely be unpredictable
behavior and/or crashes when they're used.


Shouldn't we add padding to these classes like we do elsewhere to minimise
this problem then?


Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 06-2016