[haiku-commits] Re: haiku: hrev50368 - src/kits/network/libnetapi headers/os/net

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 24 Jun 2016 23:01:22 +0200

Am 21/06/2016 um 19:10 schrieb looncraz:

On 6/21/2016 11:24, Adrien Destugues wrote:
We do this only once the class design is considered "done" and stable.
The reason is, if we add the padding early, by the time the design is
finalized, there may be not that much padding left for future evolutions
That seems like pretty poor reasoning - as adding the padding early
would result in much fewer total breakages.  Adding new padding for the
final version would only break the in-development versions from the
release versions, instead of creating numerous incompatible version
during development, leading to repeated rebuilding of dependent packages.

I must admit I just forgot about padding, although I usually indeed only add it when the class is ready for public consumption.
In this case, I think the classes mostly are, so adding padding surely doesn't hurt.

IIRC I did not put them (and some other stuff) in the private namespace, as Haiku R1 is the last to sport the current ABI anyway, and we can do any breaking changes for R2, ie. the life span of this API is supposedly short. It looked good enough for that in any case :-)


Other related posts: