[haiku-commits] Re: haiku: hrev50094 - in src: tests/kits/interface/layout/widget_layout_test servers/app/font apps/charactermap tests/kits/interface/picture preferences/locale

  • From: Axel D├Ârfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 15 Feb 2016 09:45:45 +0100

Am 14.02.2016 um 21:13 schrieb pulkomandy@xxxxxxxxxxxxx:

15325401ceef: app_server: do not return a glyph when nothing is found in the 
font.

   - Fixes BFont::GetHasGlyphs, the "empty square" which was returned led
     it to think the font had glyphs for everything
   - This means the "no character" empty square will not be drawn anymore,
     if we want it back, we will need to rework the implementation a bit
     more (either request it explicitly when there is a missing glyph, or
     return it as it was before but including an info that it is the
     "missing glyph")

I'd say we should continue to have the empty square, and fix BFont::GetHasGlyphs() to work as expected nonetheless.

   - Maybe GetHasGlyphs should also bypass the font fallback system, and
     return what's actually in the requested font only.

I would only do so with an extra flag, not by default; it's an info you're rarely interested in.

Bye,
   Axel.

Other related posts: