[haiku-commits] Re: haiku: hrev49989 - src/kits/interface headers/private/interface

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 6 Jan 2016 14:22:39 -0600

On 1/6/2016 14:10, waddlesplash@xxxxxxxxx wrote:

1d11475790d2: BAboutWindow: Put the AboutView and StripeView into BPrivate.
To avoid name clashes. Possibly fixes the HaikuDepot crashes.

That was my alternative solution :p You won't need to apply my patch which renames HaikuDepot's AboutView if you do this (though renaming it to AboutPackageView still probably makes sense ;-) ).

That said, shouldn't this not be necessary? Seems like an issue when resolving symbols.. either during compilation, or loading the ELF.

.. For observers:

HaikuDepot's AboutView (which shows information about packages) implements BView::AllAttached(), but the system pulls in AboutView::AllAttached() from BAboutWindow's implementation instead of from HaikuDepot. This only occurs on GCC4. This caused a crash in SetViewUIColor() when trying to start HaikuDepot.

Other related posts: