[haiku-commits] haiku: hrev49573 - src/servers/launch

  • From: mmlr@xxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 23 Aug 2015 15:19:43 +0200 (CEST)

hrev49573 adds 1 changeset to branch 'master'
old head: 8b9bb054f46a2500dfc4216dca18096da737debc
new head: f11d686c96f7ac06b9ea411367548d34229548a3
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=f11d686c96f7+%5E8b9bb054f46a

----------------------------------------------------------------------------

f11d686c96f7: launch_daemon: Remove extra quoting around env variables.

The extra quotes aren't needed and cause problems when not parsed
through a shell. For example LD_PRELOAD which is handled by the
runtime_loader directly failed to work as there was no way to remove
the extra single quotes.

Note that quotes and single quotes can still be added to the variables
through respective quoting in the driver settings syntax.

[ Michael Lotz <mmlr@xxxxxxxx> ]

----------------------------------------------------------------------------

Revision: hrev49573
Commit: f11d686c96f7ac06b9ea411367548d34229548a3
URL: http://cgit.haiku-os.org/haiku/commit/?id=f11d686c96f7
Author: Michael Lotz <mmlr@xxxxxxxx>
Date: Sun Aug 23 13:02:22 2015 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 2 deletions(-)
src/servers/launch/BaseJob.cpp | 3 +--

----------------------------------------------------------------------------

diff --git a/src/servers/launch/BaseJob.cpp b/src/servers/launch/BaseJob.cpp
index 3dc5d93..ef27fa1 100644
--- a/src/servers/launch/BaseJob.cpp
+++ b/src/servers/launch/BaseJob.cpp
@@ -151,7 +151,7 @@ BaseJob::SetEnvironment(const BMessage& message)
}

BString variable = name;
- variable << "='";
+ variable << "=";

const char* argument;
for (int32 argumentIndex = 0; message.FindString(name,
argumentIndex,
@@ -160,7 +160,6 @@ BaseJob::SetEnvironment(const BMessage& message)
variable << " ";
variable += argument;
}
- variable << "'";

fEnvironment.Add(variable);
}


Other related posts:

  • » [haiku-commits] haiku: hrev49573 - src/servers/launch - mmlr