[haiku-commits] Re: haiku: hrev49475 - src/kits/network/libnetapi

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 29 Jul 2015 21:09:58 +0200

On 07/29/2015 08:43 PM, waddlesplash@xxxxxxxxx wrote:

- if (status != B_OK) {
+ fStatus = status;
+ if (status != B_OK)
Unset();
- fStatus = status;
- }
return status;
}

That's absolutely not what I told you. I guess I'll better do it myself :-/
Is it really that hard to get 3 lines of code to work correctly?

Now you not only use a superfluous status variable, you also overwrite the error with Unset().

Bye,
Axel.


Other related posts: