[haiku-commits] Re: haiku: hrev49466 - in src: preferences/media servers/media

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 28 Jul 2015 00:03:03 +0200

Am 27.07.2015 um 20:30 schrieb b.vitruvio@xxxxxxxxx:

diff --git a/src/preferences/media/MediaWindow.cpp
b/src/preferences/media/MediaWindow.cpp
index 424b642..77864d6 100644
--- a/src/preferences/media/MediaWindow.cpp
+++ b/src/preferences/media/MediaWindow.cpp
@@ -164,7 +164,8 @@ MediaWindow::MediaWindow(BRect frame)
fAudioOutputs(5, true),
fVideoInputs(5, true),
fVideoOutputs(5, true),
- fInitCheck(B_OK)
+ fInitCheck(B_OK),
+ fRestartingServices(false)
{
_InitWindow();

@@ -282,6 +283,20 @@
MediaWindow::UpdateOutputListItem(MediaListItem::media_type type,
bool
MediaWindow::QuitRequested()
{
+ if (fRestartingServices == true) {

fRestartingServices is a boolean, and you named it like a boolean, too. So:

+ if (fRestartingServices) {

+ BString text(B_TRANSLATE("The media services are restarting,"
+ " interructions to this process might result"
+ " in media functionalities not correctly running."
+ " Are you really sure to quit?"));

The English above is definitely not correct. I propose:

"Quitting Media now will stop restarting the media services. Flaky or unavailable media functionality is the likely result."

+
+ BAlert* alert = new BAlert(B_TRANSLATE("Warning!"), text,
+ B_TRANSLATE("Do it"), B_TRANSLATE("No"), NULL,

"Quit anyway" "Don't quit"

In any case, I haven't looked at the ticket, but I would just hide the window and block for the media services to finish restarting. Why give the user the choice to leave media services in limbo?

Best regards,
-Stephan



Other related posts: