[haiku-commits] Re: haiku: hrev49445 - src/kits/media headers/private/media src/apps/mediaplayer src/bin/desklink src/preferences/media

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 24 Jul 2015 12:32:52 +0200

Hi Dario,

these seem like some awesome improvements! I haven't finished reviewing the patchesy, yet, but let me quickly comment on something below:

> Commit: 67483edabd465c8889dc8ffd2bf7d820e424952a

URL: http://cgit.haiku-os.org/haiku/commit/?id=67483edabd46
Author: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
Date: Thu Apr 9 13:39:04 2015 UTC

Add BMediaRoster::IsRunning

* This function is provided to check
if media services are running.

----------------------------------------------------------------------------

diff --git a/src/kits/media/MediaRoster.cpp b/src/kits/media/MediaRoster.cpp
index e0e65db..7e3e72f 100644
--- a/src/kits/media/MediaRoster.cpp
+++ b/src/kits/media/MediaRoster.cpp
@@ -3217,6 +3218,16 @@ BMediaRoster::GetInstancesFor(media_addon_id addon,
int32 flavor,
}


+bool
+BMediaRoster::IsRunning()
+{
+ if (be_roster->IsRunning(B_MEDIA_SERVER_SIGNATURE)
+ && be_roster->IsRunning(B_MEDIA_ADDON_SERVER_SIGNATURE))
+ return true;
+ return false;
+}

It would seem more elegant to write it like this:

bool
BMediaRoster::IsRunning()
{
return be_roster->IsRunning(B_MEDIA_SERVER_SIGNATURE)
&& be_roster->IsRunning(B_MEDIA_ADDON_SERVER_SIGNATURE);
}

Best regards,
-Stephan



Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 07-2015