[haiku-commits] Re: haiku: hrev49354 - src/servers/app/drawing

  • From: gus knight <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 5 Jul 2015 12:34:06 -0400

On Sun, Jul 5, 2015 at 9:43 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:

On 07/02/2015 11:43 PM, waddlesplash@xxxxxxxxx wrote:

73df8e25af7e: servers/app/drawing: BitmapHWInterface: Return -1.

-1 is the same as B_ERROR, but all of the other implementations of
this function "return -1", so do that to be consistent.


The other way around would have been the better choice IMO; you actually
return an error code.

Except that this function's return type is not a status_t, it's a
semaphore. So we return -1 here because -1 is an invalid semaphore.

-gus

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 07-2015