[haiku-commits] Re: haiku: hrev49293 - data/settings/network src/kits/network/libbind/irs src/kits/network/netresolv src/kits/network/libbind src/kits/network/netresolv/isc

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 15 Jun 2015 17:16:15 +1200

On 15 June 2015 at 01:48, <pulkomandy@xxxxxxxxxxxxx> wrote:

hrev49293 adds 11 changesets to branch 'master'
old head: 026596dd1de1cf86deaea712130cfb6a4901b6fd
new head: 842d39940425e9ee114530ae19f3fbfb9e761bf0
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=842d39940425+%5E026596dd1de1

----------------------------------------------------------------------------

0666a27d4688: Style fixes.

27dab5c12d04: freebsd_network: add __UNCONST

Needed by the new DNS resolver from NetBSD.

404cb7e3108c: BReference: missing const cast when building a BReference<const>

* The internal BReference is on a non-const object so it can increment
and decrement the reference count, so we need to cast the const away.

c6ffa94f5b9e: MediaPlayer: style fixes, print performance time of dropped
frames

* Helps understanding why the frames get dropped in some cases, where
the computed performance time is not correct.

7c3d316b5d40: Style fixes.

8d2aee6bc8f6: libbind: integrate "netresolv" patches from NetBSD.

libbind development was transferred to the NetBSD project at
http://wiki.netbsd.org/individual-software-releases/netresolv/

There isn't an official release yet, but they provide a set of patches
against the latest libbind release.

* Remove all files we don't use
* Merge the changes to the remaining files
* Add some new files we need
* Move getifaddrs implementation to libnetwork (instead of libbnetapi)
so it can be used by netresolv.

Fixes #8293 : netresolv uses getifaddrs to determine if there is a local
IPv6 address. If there is not, it will not return AAAA records.

dd0ea64b5607: Missing NULL check in network stack.

This would trigger a KDL, it's better to just fail the syscall call.

Interestingly, prior to this commit, my system locks up entirely (no
Deskbar, Tracker, or even working mouse). With this "fix" in place, I
can now boot to the desktop, however, now DHCP fails to acquire an
address. I would have to guess that the call to update the interface
triggered by DHCP is now failing (and previously, causing some sort of
mayhem), suggesting there's a nasty regression with this commit.

I've tried grokking the massive netresolv commit, but nothing has
jumped out at me thus far... it would have been nice to see the
Haiku-specific changes as a separate commit to try and reduce the area
needed to grok...

Am I the only one experiencing issues with DHCP since this commit?

Other related posts: