hrev49221 adds 4 changesets to branch 'master'
old head: 6a7370ae686215390a442df9bf49e500ff72cb29
new head: 25122be50e54e76872a62f1cf59888b00aef505b
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=25122be50e54+%5E6a7370ae6862
----------------------------------------------------------------------------
88f9012805a5: BMessage: fix an off-by-one error in SetCurrentSpecifier.
You could set the index to be past the end of the Specifier array.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Fixes #12087.
[ Alexander G. M. Smith <agmsmith@xxxxxx> ]
143edb746088: docs: makefile-engine: add missing HTML tags.
Fixes #12063.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
[ Alexander G. M. Smith <agmsmith@xxxxxx> ]
f5abc4c08ddf: Fix GCC 4.9 maybe-uninitialized warning.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
25122be50e54: Fix GCC 5 unused-variable warning.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
4 files changed, 9 insertions(+), 4 deletions(-)
docs/develop/makefile-engine.html | 7 +++++++
.../kernel/file_systems/netfs/server/ClientConnection.cpp | 2 +-
src/kits/app/Message.cpp | 2 +-
src/preferences/time/ClockView.cpp | 2 --
############################################################################
Commit: 88f9012805a53f3067a6da849b5628b3bcb32981
URL: http://cgit.haiku-os.org/haiku/commit/?id=88f9012805a5
Author: Alexander G. M. Smith <agmsmith@xxxxxx>
Date: Fri May 22 15:05:39 2015 UTC
Committer: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Commit-Date: Mon Jun 1 22:26:47 2015 UTC
Ticket: https://dev.haiku-os.org/ticket/12087
BMessage: fix an off-by-one error in SetCurrentSpecifier.
You could set the index to be past the end of the Specifier array.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Fixes #12087.
----------------------------------------------------------------------------
diff --git a/src/kits/app/Message.cpp b/src/kits/app/Message.cpp
index 6ece894..04df69f 100644
--- a/src/kits/app/Message.cpp
+++ b/src/kits/app/Message.cpp
@@ -1456,7 +1456,7 @@ BMessage::SetCurrentSpecifier(int32 index)
if (result != B_OK)
return result;
- if (index > count)
+ if (index >= count)
return B_BAD_INDEX;
fHeader->current_specifier = index;
############################################################################
Commit: 143edb7460889341714c9df8758ab765997cbcf9
URL: http://cgit.haiku-os.org/haiku/commit/?id=143edb746088
Author: Alexander G. M. Smith <agmsmith@xxxxxx>
Date: Tue May 12 17:32:22 2015 UTC
Committer: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Commit-Date: Mon Jun 1 22:28:17 2015 UTC
Ticket: https://dev.haiku-os.org/ticket/12063
docs: makefile-engine: add missing HTML tags.
Fixes #12063.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
----------------------------------------------------------------------------
diff --git a/docs/develop/makefile-engine.html
b/docs/develop/makefile-engine.html
index 923255e..9f95a34 100644
--- a/docs/develop/makefile-engine.html
+++ b/docs/develop/makefile-engine.html
@@ -1,3 +1,8 @@
+<html>
+<head>
+ <title>How To Create a Project Using Makefile Engine</title>
+</head>
+<body>
<h1>How To Create a Project Using Makefile Engine</h1>
<p>Haiku helps developers in build process of their projects by providing so
@@ -252,3 +257,5 @@ Poláčik</td>
<td align="right">Copyright © 2011 Haiku Inc.</td>
</tr>
</table>
+</body>
+</html>
############################################################################
Commit: f5abc4c08ddfa2a7fce323189fb278344da79a0f
URL: http://cgit.haiku-os.org/haiku/commit/?id=f5abc4c08ddf
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sun Apr 19 08:58:13 2015 UTC
Committer: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Commit-Date: Mon Jun 1 22:30:18 2015 UTC
Fix GCC 4.9 maybe-uninitialized warning.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
----------------------------------------------------------------------------
diff --git a/src/add-ons/kernel/file_systems/netfs/server/ClientConnection.cpp
b/src/add-ons/kernel/file_systems/netfs/server/ClientConnection.cpp
index 456d722..a224f73 100644
--- a/src/add-ons/kernel/file_systems/netfs/server/ClientConnection.cpp
+++ b/src/add-ons/kernel/file_systems/netfs/server/ClientConnection.cpp
@@ -2506,7 +2506,7 @@ void
ClientConnection::CloseNodeMonitoringEventQueue()
{
typedef Vector<NodeMonitoringRequest*> RequestVector;
- const RequestVector* requests;
+ const RequestVector* requests = NULL;
if (fNodeMonitoringEvents->Close(false, &requests) == B_OK) {
for (RequestVector::ConstIterator it = requests->Begin();
it != requests->End();
############################################################################
Revision: hrev49221
Commit: 25122be50e54e76872a62f1cf59888b00aef505b
URL: http://cgit.haiku-os.org/haiku/commit/?id=25122be50e54
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sun Apr 19 09:02:16 2015 UTC
Committer: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Commit-Date: Mon Jun 1 22:32:17 2015 UTC
Fix GCC 5 unused-variable warning.
Signed-off-by: Augustin Cavalier <waddlesplash@xxxxxxxxx>
----------------------------------------------------------------------------
diff --git a/src/preferences/time/ClockView.cpp
b/src/preferences/time/ClockView.cpp
index 4755824..0474682 100644
--- a/src/preferences/time/ClockView.cpp
+++ b/src/preferences/time/ClockView.cpp
@@ -26,8 +26,6 @@
static const char* kDeskbarSignature = "application/x-vnd.Be-TSKB";
-static const float kIndentSpacing
- = be_control_look->DefaultItemSpacing() * 2.3;
#undef B_TRANSLATION_CONTEXT