[haiku-commits] Re: haiku: hrev49042 - headers/compatibility/bsd headers/compatibility/bsd/sys src src/add-ons/kernel/bus_managers/firewire src/bin/network

  • From: François Revol <revol@xxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Apr 2015 01:29:20 +0200

On 20/04/2015 23:14, Adrien Destugues wrote:

headers/compatibility/bsd/paths.h | 8 ++++++++

It seems glibc also has paths.h around, although it's not documented in
the manpages in linux.

http://osxr.org/glibc/ident?v=glibc-2.14&_i=_PATH_BSHELL

So, should I fix the m4 recipe or should I move _PATH_BSHELL out of the
#ifdef ?

Everything non-standard should be protected by some feature defines. In
glibc, _BSD_SOURCE is enabled by default (it was renamed _DEFAULT_SOURCE
in newer versions of glibc).

Hmm right, I removed the guard but I'll add it back.

You can add -D_BSD_SOURCE to the cflags to avoid the problem in the
particular recipe you're trying to get built, or improve our headers to
have something similar to features.h.

Since m4 defines _GNU_SOURCE and expects paths.h to be here as part of
glibc, I'll just add a check for it in the guard as well, that should do.

François.

Other related posts: