hrev48973 adds 2 changesets to branch 'master'
old head: 7695c3b7eb4d636950c06fe7ca7bbeb7f979089b
new head: e587c279ee2b9625bb6b0991e7d462b840dfc066
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=e587c279ee2b+%5E7695c3b7eb4d
----------------------------------------------------------------------------
ba931975e57d: Network: fixed uninitialized members.
* CIDs 1251073, 1292681, 1292686, and 1292687 -- all irrelevant, though.
e587c279ee2b: Network/DNSClientService: fixed missing error check.
* CID 1251065.
[ Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> ]
----------------------------------------------------------------------------
5 files changed, 17 insertions(+), 4 deletions(-)
src/add-ons/network_settings/dnsclient/DNSSettingsView.cpp | 4 +++-
src/preferences/network/InterfaceListItem.cpp | 7 ++++++-
src/preferences/network/InterfaceView.cpp | 3 ++-
src/preferences/network/NetworkSettingsAddOn.cpp | 5 ++++-
src/preferences/network/ServiceListItem.cpp | 2 ++
############################################################################
Commit: ba931975e57d2c34c9093c970330898454062245
URL: http://cgit.haiku-os.org/haiku/commit/?id=ba931975e57d
Author: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
Date: Thu Apr 2 08:56:36 2015 UTC
Network: fixed uninitialized members.
* CIDs 1251073, 1292681, 1292686, and 1292687 -- all irrelevant, though.
----------------------------------------------------------------------------
diff --git a/src/preferences/network/InterfaceListItem.cpp
b/src/preferences/network/InterfaceListItem.cpp
index adb06cd..f36aa8f 100644
--- a/src/preferences/network/InterfaceListItem.cpp
+++ b/src/preferences/network/InterfaceListItem.cpp
@@ -35,7 +35,12 @@
InterfaceListItem::InterfaceListItem(const char* name)
:
BListItem(0, false),
- fIcon(NULL)
+ fIcon(NULL),
+ fFirstLineOffset(0),
+ fLineOffset(0),
+ fDisabled(false),
+ fHasLink(false),
+ fConnecting(false)
{
fInterface.SetTo(name);
_Init();
diff --git a/src/preferences/network/InterfaceView.cpp
b/src/preferences/network/InterfaceView.cpp
index f5644ad..58ca818 100644
--- a/src/preferences/network/InterfaceView.cpp
+++ b/src/preferences/network/InterfaceView.cpp
@@ -43,7 +43,8 @@ static const uint32 kMsgJoinNetwork = 'join';
InterfaceView::InterfaceView()
:
- BGroupView(B_VERTICAL)
+ BGroupView(B_VERTICAL),
+ fPulseCount(0)
{
SetFlags(Flags() | B_PULSE_NEEDED);
diff --git a/src/preferences/network/NetworkSettingsAddOn.cpp
b/src/preferences/network/NetworkSettingsAddOn.cpp
index 30f1f4f..c7a23a4 100644
--- a/src/preferences/network/NetworkSettingsAddOn.cpp
+++ b/src/preferences/network/NetworkSettingsAddOn.cpp
@@ -108,7 +108,10 @@ BNetworkInterfaceListItem::BNetworkInterfaceListItem(int
family,
fSettings(settings),
fFamily(family),
fInterface(interface),
- fLabel(label)
+ fLabel(label),
+ fDisabled(false),
+ fLineOffset(0),
+ fSpacing(0)
{
}
diff --git a/src/preferences/network/ServiceListItem.cpp
b/src/preferences/network/ServiceListItem.cpp
index 8b8d032..604fe43 100644
--- a/src/preferences/network/ServiceListItem.cpp
+++ b/src/preferences/network/ServiceListItem.cpp
@@ -27,6 +27,8 @@ ServiceListItem::ServiceListItem(const char* name, const
char* label,
fName(name),
fLabel(label),
fSettings(settings),
+ fOwner(NULL),
+ fLineOffset(0),
fEnabled(false)
{
}
############################################################################
Revision: hrev48973
Commit: e587c279ee2b9625bb6b0991e7d462b840dfc066
URL: http://cgit.haiku-os.org/haiku/commit/?id=e587c279ee2b
Author: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
Date: Thu Apr 2 09:03:58 2015 UTC
Network/DNSClientService: fixed missing error check.
* CID 1251065.
----------------------------------------------------------------------------
diff --git a/src/add-ons/network_settings/dnsclient/DNSSettingsView.cpp
b/src/add-ons/network_settings/dnsclient/DNSSettingsView.cpp
index 25b60b7..f1ee881 100644
--- a/src/add-ons/network_settings/dnsclient/DNSSettingsView.cpp
+++ b/src/add-ons/network_settings/dnsclient/DNSSettingsView.cpp
@@ -182,7 +182,9 @@ DNSSettingsView::MessageReceived(BMessage* message)
status_t
DNSSettingsView::_LoadDNSConfiguration()
{
- res_init();
+ if (res_init() != 0)
+ return B_ERROR;
+
res_state state = __res_state();
if (state != NULL) {
