[haiku-commits] Re: haiku: hrev48969 - src/apps/text_search
- From: Rene Gollent <anevilyak@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 1 Apr 2015 14:24:12 -0400
On Wed, Apr 1, 2015 at 2:10 PM, Augustin Cavalier
<waddlesplash@xxxxxxxxx> wrote:
How? If we failed to read the whole file, what exactly can we do about it?
What should we tell the user at that point?
Tell them that we failed to search due to an error at the respective step?
Right, but I figured stream processing could wait -- really, who's going to
be grepping a 2GB text file anyway?
In case you haven't noticed, TextSearch can be asked to search all
files in a subdirectory tree. Given that this has the implication that
the size of the content might not be predictable up front, it's
entirely possible it might inadvertently stumble across some giant
file that the user didn't even know about when initiating the search.
Whether it's 2GB or even "only" a hundred megabytes, this totally
isn't an acceptable approach.
Rene
Other related posts:
