[haiku-commits] Re: haiku: hrev48962 - src/apps/serialconnect

  • From: "Adrien Destugues" <pulkomandy@xxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 31 Mar 2015 06:37:03 +0000

> * Drop a few *extremely* uncommon speeds that you'll never see to
> shorten the list.

This probably breaks the baudrate setting. I think some parts of the code rely 
on the array index matching the constants used to set the baudrate in 
BSerialPort.

I don't see why these should be removed, since they are supported by our 
drivers. The menu is sorted with the fastest (probably more useful) baudrates 
first, and it won't make much difference if there are more options at the 
bottom of the menu.

In any case, these need to be reachable in some way, so please either revert 
this or add a way to set a custom baudrate (which I don't think is possible 
with our drivers and ioctl interface yet).

-- 
Adrien.

Other related posts: