[haiku-commits] Re: haiku: hrev48951 - src/system/boot/loader/file_systems/fat
- From: Travis Geiselbrecht <geist@xxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 28 Mar 2015 22:00:19 -0700
Might not be able to because of gcc 2, but I've learned a thing or two
about TRACE macros since then, I'd recommend something like this to remove
the double quotes:
#define TRACEF(str, x...) do { printf("%s:%d: " str, __PRETTY_FUNCTION__,
__LINE__, ## x); } while (0)
The x... and ## x are probably newer features than gcc 2 supports however.
Sorry I inflicted the (( )) stuff on you guys from newos.
Travis
On Sat, Mar 28, 2015 at 3:37 PM, <kallisti5@xxxxxxxxxxx> wrote:
> hrev48951 adds 1 changeset to branch 'master'
> old head: 115ac6bcaebba8001e476265d74cc2aa34e8c65b
> new head: 3f80e2801f3af12249d6f9cb9b10d1ab45433a58
> overview:
> http://cgit.haiku-os.org/haiku/log/?qt=range&q=3f80e2801f3a+%5E115ac6bcaebb
>
>
> ----------------------------------------------------------------------------
>
> 3f80e2801f3a: loader/fatfs: Fix tracing
>
> [ Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
> ]
>
>
> ----------------------------------------------------------------------------
>
> Revision: hrev48951
> Commit: 3f80e2801f3af12249d6f9cb9b10d1ab45433a58
> URL: http://cgit.haiku-os.org/haiku/commit/?id=3f80e2801f3a
> Author: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
> Date: Sat Mar 28 22:36:53 2015 UTC
>
>
> ----------------------------------------------------------------------------
>
> 1 file changed, 1 insertion(+), 1 deletion(-)
> src/system/boot/loader/file_systems/fat/Volume.cpp | 2 +-
>
>
> ----------------------------------------------------------------------------
>
> diff --git a/src/system/boot/loader/file_systems/fat/Volume.cpp
> b/src/system/boot/loader/file_systems/fat/Volume.cpp
> index c2da956..a6cbd35 100644
> --- a/src/system/boot/loader/file_systems/fat/Volume.cpp
> +++ b/src/system/boot/loader/file_systems/fat/Volume.cpp
> @@ -156,7 +156,7 @@ Volume::Volume(boot::Partition *partition)
> return;
>
> err1:
> - TRACE("fatfs: cannot mount (bad superblock ?)\n");
> + TRACE(("fatfs: cannot mount (bad superblock ?)\n"));
> // XXX !? this triple-faults in QEMU ..
> //delete fCachedBlock;
> }
>
>
>
Other related posts:
