[haiku-commits] Re: haiku: hrev48946 - src/system/kernel/fs

  • From: kallisti5 <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 30 Mar 2015 14:12:12 -0500

On 2015-03-29 15:12, Axel Dörfler wrote:

Am 28/03/2015 um 12:20 schrieb mmlr@xxxxxxxx:

3384ca1a7b85: rootfs: Fix wrong comparison for buffer reuse on rename.


Nice catch!


        // we try to reuse the existing name buffer if possible
-       if (strlen(fromName) >= strlen(toName)) {
+       if (strlen(fromName) < strlen(toName)) {


I'd say this is a very questionable optimization to begin with.
I installed Haiku to my main desktop (nightly as of yesterday after these changes) and any moderate filesystem I/O results in a complete lockup (no kdl, no crash, just hang)
Unsure if this issue existed before these changes... but raises red flags.
I'll see if I can get serial logs and do some testing of previous versions. 


 -- Alex

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 03-2015