[haiku-commits] Re: haiku: hrev48889 - src/apps/haikudepot/model

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 12 Mar 2015 15:42:51 +0100

Am 12.03.2015 um 15:40 schrieb Augustin Cavalier:
On Thu, Mar 12, 2015 at 10:07 AM, Stephan Aßmus <superstippi@xxxxxx
<mailto:superstippi@xxxxxx>> wrote:

    This is not correct, I think. If the rightsList has no entries, the
    string ends up as "© "


Actually, the line above the beginning of the diff is:
     BString publisherName = info.Vendor();
So the string will never be empty.

Maybe you are right. In case the package provides an empty vendor string, it may be good to wrap the Prepend() call within an "if (!publisherName.IsEmpty())" block.

Best regards,
-Stephan


Other related posts: