[haiku-commits] Re: haiku: hrev48743 - in src: preferences/network apps/processcontroller

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 28 Jan 2015 17:17:02 -0500

Jérôme Duval wrote:

2015-01-28 22:25 GMT+01:00<axeld@xxxxxxxxxxxxxxxx>:


@@ -2502,7 +2502,7 @@ BrowserWindow::_SmartURLHandler(const BString&  url)
                         temp = "application/x-vnd.Be.URL.";
                         temp += proto;

-                       char* argv[1] = { (char*)url.String() };
+                       const char* argv[1] = { url.String(), NULL };

                         if (be_roster->Launch(temp.String(), 1, argv) == B_OK)
                                 return;


Assigning a one-length array with two items, is this really correct?


According to the following error (from buildbot), no:

/home/builder/builds/haiku/src/apps/webpositive/BrowserWindow.cpp: In member 
function 'void BrowserWindow::_SmartURLHandler(const BString&)':
/home/builder/builds/haiku/src/apps/webpositive/BrowserWindow.cpp:2505:47: 
error: too many initializers for 'const char* [1]'
   const char* argv[1] = { url.String(), NULL };

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 01-2015