[haiku-commits] Re: haiku: hrev48729 - in src: kits/interface add-ons/input_server/filters/switch_workspace add-ons/input_server/filters/minimize_all

  • From: Adrien Destugues <pulkomandy@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 27 Jan 2015 08:00:47 +0100

On Tue, Jan 27, 2015 at 12:33:18AM +0100, jscipione@xxxxxxxxx wrote:
> a0c83527188c: Add input server filters
>   
>   ... for switching workspaces (removed from BWindow) and
>   minimize all (aka Show Desktop).
>   
>   This moves the workspace switch behavior out of the BWindow class
>   and places it into it's own input server filter that does the same
>   thing. The difference is that you may now uninstall the workspace
>   switching filter to disable the behavior. These shortcuts were not
>   included in the BeOS R5 version of BWindow so represent additional
>   behavior added to Haiku.
>   
>   minimize_all (aka Show Desktop) is a new input server filter that
>   allows you to minimize all windows by pressing cmd+ctrl+D. If
>   you do not like this behavior you may uninstall the minimize_all
>   input server filter.

I'm not sure an input_server filter for each shortcut is the best way to
go. Also, requiring user to blacklist package entries to tweak this is
not the right approach.

Shouldn't we instead go for a single "shortcuts" filter, which would be
configured from Preferences/Shortcuts, allowing to customize the
shortcuts and matched actions?

-- 
Adrien.

Other related posts: