[haiku-commits] Re: haiku: hrev48636 - src/add-ons/mail_daemon/inbound_protocols/imap build/jam/packages src/add-ons/mail_daemon/inbound_filters/notifier src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib src/add-ons/mail_daemon/inbound_protocols/pop3
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 09 Jan 2015 08:56:30 +0100
Am 08/01/2015 um 22:33 schrieb jerome.duval@xxxxxxxxx:
b9962ce: IMAP,POP3,NewMailNotification: fixed x86_64 build.
Great, thanks for cleaning up behind me!
* Notifier::HeaderFetched(): fixed the method signature (go figure how it
could
build on x86).
Not sure why it didn't on x86_64 -- the base class already implements
the method. You should only have gotten a warning about that method
shadowing the one in the base class.
* POP3: fSizes type is now std::vector<size_t> instead of BList. Please
review.
off_t might be a better choice.
Possibly, but I guess for the time being it's okay. Your changes look
good AFAICT.
Bye,
Axel.
Other related posts:
