[haiku-commits] Re: haiku: hrev48384 - src/apps/icon-o-matic/import_export/svg
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 26 Nov 2014 19:47:22 +0100
2014-11-26 19:11 GMT+01:00 Adrien Destugues <pulkomandy@xxxxxxxxx>:
> On Wed, Nov 26, 2014 at 06:06:30PM +0100, Jérôme Duval wrote:
>> 2014-11-26 14:52 GMT+01:00 <pulkomandy@xxxxxxxxxxxxx>:
>> > hrev48384 adds 1 changeset to branch 'master'
>> > old head: 42272d23426442e0463c33d26d0f90ac11e94608
>> > new head: 7b5ea03f20098299103283304e0b38f9420e89cd
>> > overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=7b5ea03+%5E42272d2
>> >
>> > ----------------------------------------------------------------------------
>> >
>> > 7b5ea03: Icon-O-Matic: import SVG gradient names.
>> >
>> > - if (gradient)
>> > + if (gradient) {
>> > style->SetGradient(gradient);
>> > + style->SetName(g->ID());
>> > + }
>>
>> Shouldn't the pointer be checked for NULL value?
>
> The only way gradient can be set is by getting it from g, so at this
> point g can't be NULL.
Right. It would be though less obscure to get the ID right away and
scope g locally as before.
Bye,
Jérôme
Other related posts:
