[haiku-commits] Re: haiku: hrev48308 - src/add-ons/kernel/file_systems/bfs

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Mon, 17 Nov 2014 13:34:01 +1300

On 17 November 2014 02:09, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> On 11/16/2014 06:45 AM, Jessica Hamilton wrote:
>>
>> Instead of making more needless commit noise, does the attached patch
>> look correct?
>
>
> Almost, I wouldn't have said anything if you had just committed, but since
> you asked... :-)
> I would use a different name like _EraseUnusedBootBlock(), and move the
> comment to a function comment, like this:
>
> /*!     Erase the first block we don't use it, and there might be
>  *      leftovers from other file systems in there.
>  */
> status_t
> Volume::_EraseUnusedBootBlock()
> {
>         [...]
> }

Thanks :-) I appreciate the feedback! I am still rather fresh
committer after all :-)

>> Also, I notice the existing code doesn't check for errors for the last
>> handful of functions. As such, I haven't added error checking for the
>> call to _PreparePartition(), unless these other function calls should
>> be addressed to also check the return values.
>
>
> Sure, error checking always makes sense :-)

The day that we can switch to exceptions will be welcome relief ;-)

Other related posts: