[haiku-commits] Re: haiku: hrev48158 - headers/posix

  • From: Paweł Dziepak <pdziepak@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 30 Oct 2014 00:35:14 +0100

2014-10-30 0:21 GMT+01:00 <zooey@xxxxxxxxxxxxxxx>:

> hrev48158 adds 1 changeset to branch 'master'
> old head: 488289a4a914e1e9b08af028a70f387ff9610b58
> new head: b9c8e3de1b3f0c9b87b8bbb6bf9d26351e17c8c8
> overview:
> http://cgit.haiku-os.org/haiku/log/?qt=range&q=b9c8e3d+%5E488289a
>
>
> ----------------------------------------------------------------------------
>
> b9c8e3d: string.h: include strings.h for compatibility.
>
>   * Partly reverting hrev47655, as the moved declarations are expected
>     by many ports to be accessable via string.h.
>     Following standards is a good thing in general, but not if it causes
>     more problems than it helps ...
>
>                                     [ Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
> ]
>
>
> ----------------------------------------------------------------------------
>
> Revision:    hrev48158
> Commit:      b9c8e3de1b3f0c9b87b8bbb6bf9d26351e17c8c8
> URL:         http://cgit.haiku-os.org/haiku/commit/?id=b9c8e3d
> Author:      Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
> Date:        Wed Oct 29 23:17:37 2014 UTC
>
>
> ----------------------------------------------------------------------------
>
> 1 file changed, 4 insertions(+)
> headers/posix/string.h | 4 ++++
>
>
> ----------------------------------------------------------------------------
>
> diff --git a/headers/posix/string.h b/headers/posix/string.h
> index 34d66bd..6f19108 100644
> --- a/headers/posix/string.h
> +++ b/headers/posix/string.h
> @@ -74,6 +74,10 @@ extern char          *strupr(char *string);
>
>  extern const char      *strsignal(int signum);
>
> +/* for compatibility, pull in functions declared in strings.h */
> +#include <strings.h>
>

Other C libraries usually use macros like _BSD_SOURCE to deal with things
like that and that would be the perfect solution. However, IIRC we don't
really use feature macros and since we got away with mixing all standards
and extensions to standards for so long it probably isn't a high priority
thing to start using them now.


> +
> +
>  #ifdef __cplusplus
>  }
>  #endif
>
>
>

Other related posts: