[haiku-commits] Re: haiku: hrev48106 - in src/apps/debugger: user_interface/gui/team_window source_language

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 26 Oct 2014 16:56:04 -0400

Hi Stephan,

On 10/26/14, Stephan Aßmus <superstippi@xxxxxx> wrote:
>> +            case MSG_SHOW_EXPRESSION_WINDOW:
>> +            {
>> +                    if (fExpressionWindow != NULL)
>> +                            fExpressionWindow->Activate(true);
>
> Here you have a race condition. You should try to Lock() as well, since
> the pointer is stale in the short time after the expression window sent
> the quit notification until it is received and set to NULL below.

Good catch, thanks. Will adjust that accordingly.

Regards,

Rene

Other related posts: