[haiku-commits] haiku: hrev48041 - in src: preferences/appearance system/kernel/fs

  • From: mmlr@xxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 18 Oct 2014 19:36:39 +0200 (CEST)

hrev48041 adds 2 changesets to branch 'master'
old head: 8635eef04236ede897a78a3896132e8223d3bffd
new head: 8ea3e9126db5df5dad3710b63db3383e8024c366
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=8ea3e91+%5E8635eef

----------------------------------------------------------------------------

cf302a3: Appearance: Increase max font size to 24 and add 16 to the list.
  
  The list went up to 24 already, but was capped by the previous max size
  of 18. Adding 16 to the arbitrary list of font sizes closes the rather
  large gap between font sizes 14 and 18 that were already in the list.
  Providing a slider or text field for the font size would probably be
  better in the long run.

8ea3e91: Typo: Fix doubled "not" in comment.

                                            [ Michael Lotz <mmlr@xxxxxxxx> ]

----------------------------------------------------------------------------

2 files changed, 3 insertions(+), 3 deletions(-)
src/preferences/appearance/FontSelectionView.cpp | 4 ++--
src/system/kernel/fs/vfs.cpp                     | 2 +-

############################################################################

Commit:      cf302a386145a7e7d7cdc8d8fa87ddbd03ab3924
URL:         http://cgit.haiku-os.org/haiku/commit/?id=cf302a3
Author:      Michael Lotz <mmlr@xxxxxxxx>
Date:        Sat Oct 18 17:17:48 2014 UTC

Appearance: Increase max font size to 24 and add 16 to the list.

The list went up to 24 already, but was capped by the previous max size
of 18. Adding 16 to the arbitrary list of font sizes closes the rather
large gap between font sizes 14 and 18 that were already in the list.
Providing a slider or text field for the font size would probably be
better in the long run.

----------------------------------------------------------------------------

diff --git a/src/preferences/appearance/FontSelectionView.cpp 
b/src/preferences/appearance/FontSelectionView.cpp
index 155beea..aef72e2 100644
--- a/src/preferences/appearance/FontSelectionView.cpp
+++ b/src/preferences/appearance/FontSelectionView.cpp
@@ -36,7 +36,7 @@
        // only on exit
 
 static const float kMinSize = 8.0;
-static const float kMaxSize = 18.0;
+static const float kMaxSize = 24.0;
 
 
 // private font API
@@ -251,7 +251,7 @@ FontSelectionView::CreateFontsMenuBarLayoutItem()
 void
 FontSelectionView::_BuildSizesMenu()
 {
-       const int32 sizes[] = {7, 8, 9, 10, 11, 12, 13, 14, 18, 21, 24, 0};
+       const int32 sizes[] = {7, 8, 9, 10, 11, 12, 13, 14, 16, 18, 21, 24, 0};
 
        // build size menu
        for (int32 i = 0; sizes[i]; i++) {

############################################################################

Revision:    hrev48041
Commit:      8ea3e9126db5df5dad3710b63db3383e8024c366
URL:         http://cgit.haiku-os.org/haiku/commit/?id=8ea3e91
Author:      Michael Lotz <mmlr@xxxxxxxx>
Date:        Sat Oct 18 17:32:33 2014 UTC

Typo: Fix doubled "not" in comment.

----------------------------------------------------------------------------

diff --git a/src/system/kernel/fs/vfs.cpp b/src/system/kernel/fs/vfs.cpp
index c2113c3..b875b90 100644
--- a/src/system/kernel/fs/vfs.cpp
+++ b/src/system/kernel/fs/vfs.cpp
@@ -882,7 +882,7 @@ lookup_vnode(dev_t mountID, ino_t vnodeID)
        If the node already exists, it is returned instead and no new node is
        created. In either case -- but not, if an error occurs -- the function 
write
        locks \c sVnodeLock and keeps it locked for the caller when returning. 
On
-       error the lock is not not held on return.
+       error the lock is not held on return.
 
        \param mountID The mount ID.
        \param vnodeID The vnode ID.


Other related posts:

  • » [haiku-commits] haiku: hrev48041 - in src: preferences/appearance system/kernel/fs - mmlr