[haiku-commits] Re: haiku: hrev47984 - src/kits/locale src/servers/mail src/kits/tracker headers/os/locale src/add-ons/mail_daemon/inbound_filters/notifier

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 08 Oct 2014 15:48:30 +0200

Am 08.10.2014 15:17, schrieb pulkomandy@xxxxxxxxxxxxx:
   * Since the BMessageFormat instances are now reused, add locking to
   avoid race conditions (ICU itself is thread safe, but the format pattern
   is recreated when the locale is changed)

IMO format objects should be as cheap as possible, and therefore should not perform any locking if possible. They also should not switch language automatically; they should really be immutable objects after construction.

Bye,
   Axel.


Other related posts: