[haiku-commits] Re: haiku: hrev47758 - src/add-ons/kernel/drivers/graphics/radeon_hd
- From: Julian Harnath <julian.harnath@xxxxxxxxxxxxxx>
- To: <haiku-commits@xxxxxxxxxxxxx>
- Date: Thu, 28 Aug 2014 22:44:55 +0200
Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> schrieb:
> On 08/28/2014 10:22 PM, julian.harnath@xxxxxxxxxxxxxx wrote:
> > +static uint32
> > +radeon_hd_pci_bar_mmio(uint16 chipsetID)
> > +{
> > + if (chipsetID < RADEON_BONAIRE)
> > + return 2;
> > + else
> > + return 5;
> > +}
>
> Superfluous "else".
> Furthermore, removing the else makes it clearer that the function
> returns something useful.
While you're right that the 'else' is not necessary, I don't really see
how it becomes clearer without it...
--
So long, Julian
Other related posts:
