[haiku-commits] Re: haiku: hrev47755 - headers/os/support
- From: Paweł Dziepak <pdziepak@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 28 Aug 2014 17:51:05 +0200
2014-08-28 17:44 GMT+02:00 <pulkomandy@xxxxxxxxxxxxx>:
> hrev47755 adds 1 changeset to branch 'master'
> old head: fbe9d6de535dd675291b58292910cc905ee676c3
> new head: 34dbbb65fdfa4a70cd2c472731bb71b16385e29f
> overview:
> http://cgit.haiku-os.org/haiku/log/?qt=range&q=34dbbb6+%5Efbe9d6d
>
>
> ----------------------------------------------------------------------------
>
> 34dbbb6: Make atomics extern "C" again.
>
> Pawel changed the implementation but I see no reason to make those
> available only from C++, so it must be an oversight.
>
These functions are static inline, what's the point of making them extern
"C" as well?
> Fixes building Haiku on Haiku which otherwise hits a mismatch in build
> compatibility headers.
>
I don't think that this mismatch should be fixed by adding more junk to
SupportDefs.h, we already have enough ifdefs in there.
>
> [ Adrien Destugues <pulkomandy@xxxxxxxxx>
> ]
>
>
> ----------------------------------------------------------------------------
>
> Revision: hrev47755
> Commit: 34dbbb65fdfa4a70cd2c472731bb71b16385e29f
> URL: http://cgit.haiku-os.org/haiku/commit/?id=34dbbb6
> Author: Adrien Destugues <pulkomandy@xxxxxxxxx>
> Date: Thu Aug 28 17:44:09 2014 UTC
>
>
> ----------------------------------------------------------------------------
>
> 1 file changed, 7 insertions(+)
> headers/os/support/SupportDefs.h | 7 +++++++
>
>
> ----------------------------------------------------------------------------
>
> diff --git a/headers/os/support/SupportDefs.h
> b/headers/os/support/SupportDefs.h
> index 7e47018..476d42c 100644
> --- a/headers/os/support/SupportDefs.h
> +++ b/headers/os/support/SupportDefs.h
> @@ -217,6 +217,9 @@ extern void* get_stack_frame(void);
>
> #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
>
> static inline void
> atomic_set(int32* value, int32 newValue)
> @@ -319,6 +322,10 @@ atomic_get64(int64* value)
> return __atomic_load_n(value, __ATOMIC_ACQUIRE);
> }
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
>
> #else // __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)
>
>
>
>
Other related posts:
