[haiku-commits] Re: haiku: hrev47655 - headers/posix src/bin src/apps src/kits src/kits/tracker

  • From: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 27 Aug 2014 11:02:23 -0500

On , pulkomandy wrote:
On Wed, Aug 27, 2014 at 09:23:12AM -0400, Augustin Cavalier wrote:
On Tue, Aug 26, 2014 at 7:17 PM, Alexander von Gluck IV <
kallisti5@xxxxxxxxxxx> wrote:

> Everywhere I look, string.h includes strcasecmp.
> Please fix ASAP, and test better before making such core posix API changes.

Indeed, the Qt4 build is also broken due to this.

Please fix Qt (and everything then). The POSIX page for string.h,
strings.h and strcasecmp are fairly clear on this.

There's a reason for it too: string.h is a C99 header, and all POSIX
extensions go in the separate strings.h.

The fact that some systems wrongly pollute C99 headers with POSIX stuff
is not a reason to follow them.

Hm, I agree but a lot of projects may not accept these patches.
Windows provides only "string.h", so changing to strings.h breaks things that
build on Windows + UNIX.

I just tried to get a change into Mesa and they rejected as it "works
everywhere else at the moment"

I think we're just causing more trouble than it's worth for patches. We need to pick our battles. leave strcasecmp in the string.h and wrap it with comments
that it is there for "legacy compatibility only"

 -- Alex

Other related posts: