[haiku-commits] haiku: hrev47650 - in src: kits/tracker system/kernel/arch/arm
- From: pulkomandy@xxxxxxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 8 Aug 2014 08:37:12 +0200 (CEST)
hrev47650 adds 2 changesets to branch 'master'
old head: 295ded8c41b0dacba43c34ffb65ce67acaf2f779
new head: 51a0d540e504a4a5d458b51e5fe63c0484a6f823
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=51a0d54+%5E295ded8
----------------------------------------------------------------------------
fea7eea: Check if gARMPagingMethod is null
in arch_vm_translation_map_is_kernel_page_accessible. Fix borrowed from x86
(commit 428b9e758c30a95154f5ad0d974894ef9ae133d6).
Signed-off-by: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Fixes #11107.
[ Arvind S Raj <sraj.arvind@xxxxxxxxx> ]
51a0d54: Even more optimization of this list iteration.
I hope everyone is happy, now.
[ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]
----------------------------------------------------------------------------
2 files changed, 4 insertions(+), 1 deletion(-)
src/kits/tracker/PoseViewScripting.cpp | 2 +-
src/system/kernel/arch/arm/arch_vm_translation_map.cpp | 3 +++
############################################################################
Commit: fea7eea41727c4be8172a2465e752fbc30d7ccf4
URL: http://cgit.haiku-os.org/haiku/commit/?id=fea7eea
Author: Arvind S Raj <sraj.arvind@xxxxxxxxx>
Date: Thu Aug 7 11:52:48 2014 UTC
Committer: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Commit-Date: Fri Aug 8 06:37:12 2014 UTC
Ticket: https://dev.haiku-os.org/ticket/11107
Check if gARMPagingMethod is null
in arch_vm_translation_map_is_kernel_page_accessible. Fix borrowed from x86
(commit 428b9e758c30a95154f5ad0d974894ef9ae133d6).
Signed-off-by: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Fixes #11107.
----------------------------------------------------------------------------
diff --git a/src/system/kernel/arch/arm/arch_vm_translation_map.cpp
b/src/system/kernel/arch/arm/arch_vm_translation_map.cpp
index faad4bf..6fc4ba1 100644
--- a/src/system/kernel/arch/arm/arch_vm_translation_map.cpp
+++ b/src/system/kernel/arch/arm/arch_vm_translation_map.cpp
@@ -145,5 +145,8 @@ bool
arch_vm_translation_map_is_kernel_page_accessible(addr_t virtualAddress,
uint32 protection)
{
+ if(!gARMPagingMethod)
+ return true;
+
return gARMPagingMethod->IsKernelPageAccessible(virtualAddress,
protection);
}
############################################################################
Revision: hrev47650
Commit: 51a0d540e504a4a5d458b51e5fe63c0484a6f823
URL: http://cgit.haiku-os.org/haiku/commit/?id=51a0d54
Author: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Date: Fri Aug 8 06:28:24 2014 UTC
Even more optimization of this list iteration.
I hope everyone is happy, now.
----------------------------------------------------------------------------
diff --git a/src/kits/tracker/PoseViewScripting.cpp
b/src/kits/tracker/PoseViewScripting.cpp
index 41781bb..e6619fa 100644
--- a/src/kits/tracker/PoseViewScripting.cpp
+++ b/src/kits/tracker/PoseViewScripting.cpp
@@ -466,7 +466,7 @@ BPoseView::DeleteProperty(BMessage* specifier, int32 form,
} else
Delete(entryList, false,
settings.AskBeforeDeleteFile());
} else {
- for (int i = 0; i < entryList->CountItems(); i++)
+ for (int i = entryList->CountItems() - 1; i >= 0; i--)
delete entryList->ItemAt(i);
delete entryList;
}
Other related posts:
