[haiku-commits] Re: haiku: hrev47421 - src/apps/debugger/user_interface/gui/team_window
- From: Rene Gollent <anevilyak@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 25 Jun 2014 14:57:42 -0400
On Wed, Jun 25, 2014 at 2:22 PM, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> Unfortunately the query is performed in the window thread which is not
> acceptable. The request probably doesn't need to be passed back to the
> TeamDebugger, but it should at least happen in a separate thread. It might
Will adjust that accordingly. I didn't think that would be a problem
since it's doing a case-exact query with no wildcards, which is in my
experience near-instantaneous, but I suppose that might not be the
case if there's a lot of concurrent disk access.
> also be a good idea to start the query already as soon as we notice that we
> don't know where to find the source file, so that we already have the result
> when the user clicks the view.
Would need to think about that a bit, my only concern/hesitation there
is if the user switches which file is the visible one (i.e. by
switching to a different image/function first) before attempting to
resolve the missing source, then we'd have to track that and keep the
current list of matches in sync with that, which complicates things
significantly.
Regards,
Rene
Other related posts:
