[haiku-commits] Re: haiku: hrev47386 - src/apps/webpositive

  • From: Paweł Dziepak <pdziepak@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 16 Jun 2014 13:44:01 +0200

2014-06-16 12:49 GMT+02:00  <pulkomandy@xxxxxxxxxxxxx>:
> hrev47386 adds 1 changeset to branch 'master'
> old head: da802e25b747b4c1c280d3be5acfeb2d2fc18fef
> new head: 1ff6e7a80ff211ca53e6bf7f8fdd5e2fed193022
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=1ff6e7a+%5Eda802e2
>
> ----------------------------------------------------------------------------
>
> 1ff6e7a: More correct label for the save page menu item
>
>   Use "Save page as…" since the item will open a save panel.
>
>                              [ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]
>
> ----------------------------------------------------------------------------
>
> Revision:    hrev47386
> Commit:      1ff6e7a80ff211ca53e6bf7f8fdd5e2fed193022
> URL:         http://cgit.haiku-os.org/haiku/commit/?id=1ff6e7a
> Author:      Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
> Date:        Mon Jun 16 10:47:33 2014 UTC
>
> ----------------------------------------------------------------------------
>
> 1 file changed, 1 insertion(+), 1 deletion(-)
> src/apps/webpositive/BrowserWindow.cpp | 2 +-
>
> ----------------------------------------------------------------------------
>
> diff --git a/src/apps/webpositive/BrowserWindow.cpp 
> b/src/apps/webpositive/BrowserWindow.cpp
> index eb1bd9e..e3c46f4 100644
> --- a/src/apps/webpositive/BrowserWindow.cpp
> +++ b/src/apps/webpositive/BrowserWindow.cpp
> @@ -400,7 +400,7 @@ BrowserWindow::BrowserWindow(BRect frame, 
> SettingsMessage* appSettings,
>                 new BMessage(B_QUIT_REQUESTED), 'W', B_SHIFT_KEY));
>         menu->AddItem(new BMenuItem(B_TRANSLATE("Close tab"),
>                 new BMessage(CLOSE_TAB), 'W'));
> -       menu->AddItem(new BMenuItem(B_TRANSLATE("Save page"),
> +       menu->AddItem(new BMenuItem(B_TRANSLATE("Save page 
> as"B_UTF8_ELLIPSIS),

C++11 (and I think our code style guidelines also) requires a space
between "Save page as" and B_UTF8_ELLIPSIS.

>                 new BMessage(SAVE_PAGE), 'S'));
>         menu->AddSeparatorItem();
>         menu->AddItem(new BMenuItem(B_TRANSLATE("Downloads"),
>
>

Other related posts: