[haiku-commits] haiku: hrev47169 - src/apps/debugger/user_interface/gui/team_window

  • From: anevilyak@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 26 Apr 2014 03:54:38 +0200 (CEST)

hrev47169 adds 1 changeset to branch 'master'
old head: 667cfcdd569bc74ad9b778ed4214638272996f36
new head: e10e704441cb6df01b1e8a4765cac7e8e22a0041
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=e10e704+%5E667cfcd

----------------------------------------------------------------------------

e10e704: Debugger: Fix crash in context menu builder.
  
  A value node might not have a location due to e.g. issues resolving its 
parent.
  Guard against this case and simply return early as we won't be able to take 
any
  meaningful actions on such a node. Fixes the second crash listed in #10781.

                                         [ Rene Gollent <rene@xxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev47169
Commit:      e10e704441cb6df01b1e8a4765cac7e8e22a0041
URL:         http://cgit.haiku-os.org/haiku/commit/?id=e10e704
Author:      Rene Gollent <rene@xxxxxxxxxxx>
Date:        Sat Apr 26 01:51:47 2014 UTC

Ticket:      https://dev.haiku-os.org/ticket/10781

----------------------------------------------------------------------------

1 file changed, 3 insertions(+)
src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp | 3 +++

----------------------------------------------------------------------------

diff --git a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp 
b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp
index b3cd434..5d75846 100644
--- a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp
+++ b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp
@@ -2042,6 +2042,9 @@ VariablesView::_GetContextActionsForNode(ModelNode* node,
        ContextActionList* actions)
 {
        ValueLocation* location = node->NodeChild()->Location();
+       if (location == NULL)
+               return B_OK;
+
        status_t result = B_OK;
        BMessage* message = NULL;
 


Other related posts:

  • » [haiku-commits] haiku: hrev47169 - src/apps/debugger/user_interface/gui/team_window - anevilyak