[haiku-commits] Re: haiku: hrev47167 - src/apps/webpositive

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 25 Apr 2014 10:13:19 +0200 (CEST)

> On April 25, 2014 at 7:39 AM Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
> wrote:
> > c620610: WebPositive: Add support to show/hide bookmark bar
> > Default is shown, a menu option in the View menu allows you to show
> > or hide the bar.
> This should be in the preferences window, with the "hide tab bar when there
> are no tabs" option.
> And it should be saved to Web+ settings there (and make use of the
> revert/defaults buttons.

Can't we just hide it as long as it is empty, saving the option completely? It
doesn't look good empty, anyway.

> > Also move the bookmark bar below the tab frame, it looks better
> > here I think and matches other browsers (e.g. Firefox.)
> I put it above the tabs on purpse, because it matches our behavior: the
> bookmarks open in new tabs.

That should be changed to match the usual behavior, ie. left click opens in
current tab, middle click in a new tag.
Always opening bookmarks in a new tab is an inferior solution IMO.

Bye,
   Axel.

Other related posts: