[haiku-commits] Re: haiku: hrev46943 - src/preferences/screensaver
- From: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 26 Feb 2014 18:13:14 -0600
On 02/26/2014 04:59 PM, jscipione@xxxxxxxxx wrote:
> hrev46943 adds 2 changesets to branch 'master'
> old head: 46b39e837829ece251b2a5a690b86d283a95c2c5
> new head: 58b592b3b5dd2e4031f12279867cb0a20855d377
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=58b592b+%5E46b39e8
>
> ----------------------------------------------------------------------------
>
> 0591d84: ScreenSaver: Refactor ModulesView
>
> Create controls in initializer list of constructor, delete controls in
> the (newly-added) destructor.
>
> Make fSettings the first private member.
>
> 58b592b: ScreenSaver: Add "No preview available" text
>
> ... when a screensaver doesn't provide a preview.
>
> Also do a bit of refactoring in PreviewView, remove unneeded includes
>
> [ John Scipione <jscipione@xxxxxxxxx> ]
MkDir1
/Buildbot/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/preferences/screensaver
C++
/Buildbot/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/preferences/screensaver/ScreenSaverApp.o
C++
/Buildbot/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/preferences/screensaver/ScreenSaverWindow.o
C++
/Buildbot/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/preferences/screensaver/PasswordWindow.o
C++
/Buildbot/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/preferences/screensaver/PreviewView.o
/Buildbot/slave/haiku/src/preferences/screensaver/PreviewView.cpp: In
member function 'BView* PreviewView::AddPreview()':
/Buildbot/slave/haiku/src/preferences/screensaver/PreviewView.cpp:121:31: error:
taking address of temporary [-fpermissive]
&(rgb_color){ 255, 255, 255 });
^
*cough*
Other related posts:
