[haiku-commits] Re: haiku: hrev46890 - src/apps/packageinstaller

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 19 Feb 2014 09:17:46 +0100

On 19.02.2014 02:10, jscipione@xxxxxxxxx wrote:
hrev46890 adds 1 changeset to branch 'master'
old head: 0992d43c0b5d835c5e4ca67f8a7329850f24c8b8
new head: 1d5c1fc35d04f9daf080bb5005674c89a05c5542
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=1d5c1fc+%5E0992d43

----------------------------------------------------------------------------

1d5c1fc: packageinstaller: style fixes

                                      [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------
[...]
-                               // Check whether the message means someone 
dropped a file
+                               // check whether the message means someone 
dropped a file
                                // to our view

There is nothing in the coding guidelines about this, so I find these changes unnecessary. The coding guideline example is messy in this regard and I'm thinking about fixing that. It even has one place with a complete sentence including punctuation where the first letter is not capitalized. It also shows sentences that have no punctuation that are or are not capitalized, incomplete sentences that are capitalized and some that are not. So if anything, the coding guidelines should demonstrate that there is no rule about it.

Best regards,
-Stephan



Other related posts: