[haiku-commits] Re: haiku: hrev46887 - in src: apps/packageinstaller kits/interface

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 19 Feb 2014 09:29:20 +0100

On 19.02.2014 02:19, John Scipione wrote:
Below are a couple of patches that I made to fix up package installer.
I didn't want to step on your toes though so I'll let you apply them
(if you'd like).

The first patch renames the "Install" button to "Begin". As you know,
many BeOS apps copied the sample text so they hardcode the button name
"Begin" in the description.

Have you considered that the button will usually be translated? So it will not be "Begin" for anything but English installs anyway.

The second patch right aligns the menu field labels once again and
also adds glue to the right of the destination menu field.

I've had it that way until deciding that left-aligning looks better. There is one additional alignment in the window that way. Depending on the language and the length of the labels, right-aligning looks like an error, if the indentation of one of the labels is only small (for example in the German translation).

Best regards,
-Stephan



Other related posts: